BlocksRuntime: Export all NSConcrete* globals on Win32 #7
+1
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BLOCK_EXPORT expands to 'extern' or 'extern "C"'.
NSConcrete* globals need to be exported for runtime integration (libobjc2 for example).
This was referenced Oct 24, 2025
compnerd
reviewed
Oct 24, 2025
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up. Do you know where the code generation occurs for the newly added isa pointers?
Author
|
@compnerd do you know when the change in LLVM was made? I would like to add it to the commit message. |
Member
llvm/llvm-project#125384 is what added the static runtime support; llvm/llvm-project@442b88b added the original support for PE/COFF support in the Blocks CG. |
compnerd
approved these changes
Oct 31, 2025
Member
|
This looks pretty close to perfect. The only thing that is missing is just testing the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libobjc2 runtime supports integration with an external blocks runtime. For this to work, it needs access to the NSConcrete* globals. Some of them are already exported in the def file.
I have also removed an unused CMakeLists and fixed compilation on Windows.