Revert "Add support for 32-bit reflection contexts."

[compnerd]

Reverts #3590

This regressed the Windows builds: https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/7267/consoleText

[compnerd]

@swift-ci please test

[compnerd]

CC: @JDevlieghere @adrian-prantl

[adrian-prantl]

Ah thanks. MSVC at work again. I'll see if I can figure out what it's unhappy about.

[adrian-prantl]

@compnerd
If I have to make a wild guess, this patch might fix it:

diff --git a/lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeImpl.h b/lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeImpl.h
index 711c36941495..93e66b0892f1 100644
--- a/lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeImpl.h
+++ b/lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeImpl.h
@@ -210,7 +210,7 @@ public:
     virtual bool addImage(
         llvm::function_ref<std::pair<swift::remote::RemoteRef<void>, uint64_t>(
             swift::ReflectionSectionKind)>
-            find_section);
+            find_section) = 0;
     virtual bool addImage(swift::remote::RemoteAddress image_start) = 0;
     virtual bool readELF(swift::remote::RemoteAddress ImageStart,
                          llvm::Optional<llvm::sys::MemoryBlock> FileBuffer) = 0;

[compnerd]

Could you put up a PR with that? It should be easy to trigger a cross-repo test to quickly verify.

[adrian-prantl]

Github doesn't let me create new PRs right now, but I'd give that a try before reverting the patch.

[adrian-prantl]

I'll ping here as soon as it's possible again.

[compnerd]

Actually, I quickly tested locally, you're right, that does fix it. Let's get that in ASAP.

[adrian-prantl]

#3611

[adrian-prantl]

#3611