Skip to content

fix(es/resolver): Ignore VarDecl with declare: true #9734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kdy1 merged 10 commits into from
Nov 11, 2024
Merged

fix(es/resolver): Ignore VarDecl with declare: true #9734

kdy1 merged 10 commits into from
Nov 11, 2024

Conversation

@kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 11, 2024

Description:

declare const MY_MAGIC_VARIABLE: string is not a variable declaration.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Nov 11, 2024
@kdy1 kdy1 self-assigned this Nov 11, 2024
@kdy1 kdy1 marked this pull request as ready for review November 11, 2024 12:56
@kdy1 kdy1 requested a review from a team as a code owner November 11, 2024 12:56
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9c9c181

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 11, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 11, 2024
View reviewed changes
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9734 will not alter performance

Comparing kdy1:fix-const-declare (9c9c181) with main (92faf5b)

Summary

✅ 194 untouched benchmarks

@kdy1 kdy1 enabled auto-merge (squash) November 11, 2024 21:42
@kdy1 kdy1 merged commit aa0f784 into swc-project:main Nov 11, 2024
151 of 152 checks passed
@kdy1 kdy1 deleted the fix-const-declare branch November 11, 2024 22:11
@kdy1 kdy1 mentioned this pull request Nov 12, 2024
Merged
kdy1 added a commit to vercel/next.js that referenced this pull request Nov 12, 2024
@kdy1
Update swc_core to v5.0.4 from v5.0.1 (#72604)
cd82914 
### What?

Update `swc_core` to `v5.0.4`.

ChangeLog:
swc-project/swc@[email protected][email protected]

### Why?

To apply swc-project/swc#9734


### How?

Closes PACK-3445
Fixes #72576
@kdy1 kdy1 modified the milestones: Planned, 1.9.3 Nov 22, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels

None yet

Milestone

1.9.3

Development

Successfully merging this pull request may close these issues.

1 participant

@kdy1