fix(decorators): fix private decorator regressions (issue #9565)#11563
Closed
fix(decorators): fix private decorator regressions (issue #9565)#11563
Conversation
This fixes issue #9565 where decorators on private fields were not working correctly. The main problem was that `_initProto` was being injected into private field initializers, causing `addInitializer` callbacks to fail when they tried to access private fields. The fix ensures `_initProto(this)` is only injected into public field initializers or the constructor, not into private field initializers. This is because private fields are not accessible until their initializer has completed, so any `addInitializer` callback that tries to access a private field during its own initialization would fail. Closes #9565 Co-authored-by: Donny/강동윤 <[email protected]>
|
|
|
Contributor
Binary Sizes
Commit: e72f9de |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Closes #9565