refactor(es/minifier): use node id

[bvanjoi]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4f77597

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kdy1]

So you want to make node id a cache of Id, instead of making them unique?
If so, I think the field name is wrong.

[bvanjoi]

If so, I think the field name is wrong.

I don't understand what this statement refers to. Could you please provide a detailed explanation?

Additionally, I should note that this approach is still under exploration, I can't draw definitive conclusions until testing is complete.

[kdy1]

Okay, I'll wait for the result

[codspeed-hq]

CodSpeed Performance Report

Merging #10998 will not alter performance

_{Comparing bvanjoi:useless-field (4f77597) with main (038964a)}

Summary

✅ 122 untouched benchmarks
⁉️ 18 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⁉️	es/minifier/libs/antd	1.9 s	N/A	N/A
⁉️	es/minifier/libs/d3	384.4 ms	N/A	N/A
⁉️	es/minifier/libs/echarts	1.5 s	N/A	N/A
⁉️	es/minifier/libs/jquery	95.1 ms	N/A	N/A
⁉️	es/minifier/libs/lodash	111.7 ms	N/A	N/A
⁉️	es/minifier/libs/moment	61.5 ms	N/A	N/A
⁉️	es/minifier/libs/react	19.2 ms	N/A	N/A
⁉️	es/minifier/libs/terser	341.1 ms	N/A	N/A
⁉️	es/minifier/libs/three	632.4 ms	N/A	N/A
⁉️	es/minifier/libs/typescript	3.7 s	N/A	N/A
⁉️	es/minifier/libs/victory	838.1 ms	N/A	N/A
⁉️	es/minifier/libs/vue	140.1 ms	N/A	N/A
⁉️	es/fixer/typescript	202.8 ms	N/A	N/A
⁉️	es/hygiene/typescript	426.5 ms	N/A	N/A
⁉️	es/resolver/typescript	244.3 ms	N/A	N/A
⁉️	es/resolver_with_hygiene/typescript	735.4 ms	N/A	N/A
⁉️	hygiene/typescript	21.4 s	N/A	N/A
⁉️	resolver/typescript	12.3 s	N/A	N/A

[socket-security]

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​babel/​traverse@​7.22.1
	@​types/​terser@​3.12.0
	@​ast-grep/​napi-darwin-arm64@​0.3.3
	@​ast-grep/​napi-darwin-x64@​0.3.3
	@​ast-grep/​napi-linux-x64-gnu@​0.3.3
	@​ast-grep/​napi-win32-arm64-msvc@​0.3.3
	@​ast-grep/​napi-win32-ia32-msvc@​0.3.3
	@​ast-grep/​napi-win32-x64-msvc@​0.3.3
	@​swc/​counter@​0.1.3
	node-releases@​2.0.13
	hasown@​2.0.2
	is-core-module@​2.12.1
	function-bind@​1.1.2
	@​swc/​plugin-jest@​1.5.117
	@​babel/​plugin-transform-react-jsx-development@​7.18.6
	jest-get-type@​25.2.6 ⏵ 29.6.3			+1
	@​babel/​plugin-syntax-async-generators@​7.8.4
	@​babel/​plugin-syntax-import-meta@​7.10.4
	@​babel/​plugin-syntax-json-strings@​7.8.3
	@​babel/​plugin-syntax-logical-assignment-operators@​7.10.4
	@​babel/​plugin-syntax-nullish-coalescing-operator@​7.8.3
	@​babel/​plugin-syntax-numeric-separator@​7.10.4
	@​babel/​plugin-syntax-object-rest-spread@​7.8.3
	@​babel/​plugin-syntax-optional-catch-binding@​7.8.3
	@​babel/​plugin-syntax-optional-chaining@​7.8.3
	@​babel/​plugin-syntax-dynamic-import@​7.8.3
	@​babel/​plugin-syntax-export-namespace-from@​7.8.3
	@​babel/​plugin-syntax-private-property-in-object@​7.14.5
	@​babel/​plugin-transform-dotall-regex@​7.18.6
	@​babel/​plugin-transform-unicode-regex@​7.18.6
	@​babel/​plugin-syntax-class-properties@​7.12.13
	@​babel/​plugin-syntax-class-static-block@​7.14.5
	@​babel/​plugin-syntax-top-level-await@​7.14.5
See 244 more rows in the dashboard

View full report