Skip to content

fix(es/analysis): Support comments #10299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kdy1 merged 1 commit into from
Mar 31, 2025
Merged

fix(es/analysis): Support comments #10299

kdy1 merged 1 commit into from
Mar 31, 2025

Conversation

@kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 31, 2025

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Mar 31, 2025
@kdy1 kdy1 self-assigned this Mar 31, 2025
@kdy1 kdy1 requested a review from a team as a code owner March 31, 2025 07:38
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025

⚠️ No Changeset found

Latest commit: d5d16d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) March 31, 2025 07:38
@kdy1 kdy1 disabled auto-merge March 31, 2025 07:59
@kdy1 kdy1 merged commit 2919d16 into main Mar 31, 2025
163 checks passed
@kdy1 kdy1 deleted the kdy1/analysis-comments branch March 31, 2025 07:59
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 31, 2025

CodSpeed Performance Report

Merging #10299 will degrade performances by 1.32%

Comparing kdy1/analysis-comments (d5d16d1) with main (a53c60d)

Summary

❌ 1 regressions
✅ 151 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ es/lints/libs/d3 27.8 ms 28.1 ms -1.32%

@kdy1 kdy1 modified the milestones: Planned, v1.11.14 Mar 31, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels

None yet

Milestone

v1.11.14

Development

Successfully merging this pull request may close these issues.

2 participants

@kdy1