Skip to content

Conversation

@ponelat
Copy link
Contributor

@ponelat ponelat commented Apr 23, 2017

remove object-assign dep ( which was missing from package.json )

revert to older react version, may break editor

Don't merge this until swagger-editor (insert-pr-here) is merged

@ponelat ponelat force-pushed the feature/older-react branch from cf870d5 to cbef3f4 Compare April 23, 2017 15:06
@ponelat ponelat requested a review from shockey April 23, 2017 15:06
@shockey shockey changed the title Use older version of react (^15.0.0) and remove object-assign WIP: Use older version of react (^15.0.0) and remove object-assign Apr 23, 2017
@shockey
Copy link
Contributor

shockey commented Apr 23, 2017

Added WIP to title. @ponelat ping me when the corresponding editor PR is ready 😄

@ponelat ponelat changed the title WIP: Use older version of react (^15.0.0) and remove object-assign Remove object-assign Apr 25, 2017
@ponelat ponelat force-pushed the feature/older-react branch from cbef3f4 to 4276680 Compare April 25, 2017 08:19
@ponelat
Copy link
Contributor Author

ponelat commented Apr 25, 2017

@shockey too much effort to downgrade react across it. Went with another solution for my particular need.
Made this PR about the object-assign thing only ( renamed title, to match ).
Should be good to merge. Not sure how this worked before... since the package.json didn't include any reference to object-assign package.

@shockey
Copy link
Contributor

shockey commented Apr 26, 2017

@ponelat merge conflict, please fix, i'm not able to add commits to your branch 😄

@ponelat
Copy link
Contributor Author

ponelat commented Apr 28, 2017

hello dist/ fol-der my friend....
I've come to re-compile again.

In restless issues we walked alone
Narrow streets of cobble-stone

'Neath the halo of a merge-conflict
I turned my collar to the cold and damp
When my eyes were stabbed by the flash of a notification

That split the night
And touched the sound of compiling

@ponelat ponelat force-pushed the feature/older-react branch from 4276680 to f5e89dc Compare April 28, 2017 09:20
@shockey shockey merged commit 11e9bbf into master Apr 28, 2017
@ponelat ponelat deleted the feature/older-react branch April 29, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants