Why use globals?

[MattiSG]

This library seems to be relying on a large amount of globals to function. This is surprising, as leaking state-holding variables in the global namespace is most often considered bad practice, for it leads to potential conflicts with other libraries and decreased maintainability.

However, this practice seems absolutely conscious and voluntary in this project, as these variables are prefixed with window. to expose them globally on the browser.

As this practice makes me extremely wary of including the library as it is, I would like to know what is the rationale for exposing so many globals (and requesting clients to do so too).

[MattiSG]

@fehguy Does adding the “Feature” tag mean removing globals is an expected feature?

[fehguy]

@MattiSG it means we're going to look into it during that milestone but in general being assigned to a milestone doesn't mean we are for sure going to do it. But in this case, yes, it will be fixed.

reference swagger-api/swagger-js#178

[timstott]

Hello fellow swagger-ui folks!
I've just come across a use case where using globals breaks swagger-ui 😔. That is to have multiple instances of swaggerUi on the same page. I wish to aggregate multiple swagger apis in one page.

I did a very quick spike at removing globals but it wasn't enough timstott/swagger-ui@6a883cc. Partial success (or failure 😄).
I would help but unfortunately I'm not familiar with coffee script at all.

👍 to allow instantiating multiple SwaggerUi object. (also swagger-ui is awesome, thank you for the great work)

[MattiSG]

@timstott That's obviously the main conflictual case. I solved this by resolving to iframe, FWIW.

[fehguy]

Yes understood, this fix is slated for the m2 release.

[mohsen1]

This duplicate of #851

I think for now using <iframe> is the best option