Skip to content

[markup] Span/Link/Div are not Buttons! #1752

@frol

Description

@frol

Please, don't use span/div/a as buttons.

There is at least one place where I bumped into this - OAuth2 On/Off switch, which is a span with an image on background. You won't know that there is a button at all while the image isn't loaded. I bumped into the issue when the image was corrupted (testing PR #1589) and I spent an hour debugging JS because the corrupted image hasn't even raised a notice in Dev Tools (I would noticed 404 errors for example, but there was silence and I thought something is wrong in JS logic)!

Thank you all contributors for this great project!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions