Skip to content

Conversation

@EduMenges
Copy link

@EduMenges EduMenges commented Aug 13, 2025

Description

This fixes the problem when a v3.1 schema that has booleanSchemaValue set to false gets mapped to true during the resolveSchemaRef method, since the visitedMap lookup returns the first insertion it got.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor (non-breaking change)
  • 🧪 Tests
  • 📝 Documentation
  • 🧹 Chore (build or tooling)

Checklist

  • I have added/updated tests as needed
  • I have added/updated documentation where applicable
  • The PR title is descriptive
  • The code builds and passes tests locally
  • I have linked related issues (if any)

Screenshots / Additional Context

@ewaostrowska
Copy link
Contributor

Hi @EduMenges,
Thank you for creating the PR and pointing to the issue. I have created a PR with tests for these changes to make sure everything works as expected for proposed changes. Thanks again for your input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants