fix to Go client template to address localVarFile error #9527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@psaffrey-origami, thanks for PR, once jenkins completes its tasks i'll merge the PR |
|
Any luck getting this PR merged? |
|
@HugoMario is there anything stopping this PR from being merged? |
Contributor
|
Hi @danny-cheung , sorry for delay, i had missed this one, sorry about it :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
This is a recapitulation of #8051 which seems to have gone nearly all the way to being merged. It's such a small change it seemed easier to recreate it from an up-to-date copy of
master.The PR addresses #9431 - following the instructions in that issue should show the bug in master and how this PR provides a fix.
This is my first PR against swagger-codegen so happy to hear any suggestions or comments. I'd like to use swagger-codegen in a project and need this fix to avoid having to use a non-standard version.