-
Notifications
You must be signed in to change notification settings - Fork 6k
Adding qt project generation fix #7784 #7799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding qt project generation fix #7784 #7799
Conversation
|
As you can see, the tests are failing: What am I missing? |
| supportingFiles.add(new SupportingFile("modelFactory.mustache", sourceFolder, PREFIX + "ModelFactory.h")); | ||
| supportingFiles.add(new SupportingFile("object.mustache", sourceFolder, PREFIX + "Object.h")); | ||
| if (optionalProjectFileFlag) { | ||
| supportingFiles.add(new SupportingFile("Project.mustache", "", "client.pri")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are missing the mustache file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also check the processOpts function
|
travis build failed but it doesn't seems to be related to my modification, am I right? Now I just need to fill |
I think, but i am not sure |
|
Ok I implemented the mustache part. Let me know if it looks good to you! Ping @ravinikam @stkrwork @fvarose |
| {{/apis}} | ||
| {{/apiInfo}} | ||
| # Others | ||
| $${PWD}/SWGHelpers.cpp \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$${PWD}/{{prefix}}Helpers.cpp \
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| {{/apiInfo}} | ||
| # Others | ||
| $${PWD}/SWGHelpers.cpp \ | ||
| $${PWD}/SWGHttpRequest.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
| {{/apis}} | ||
| {{/apiInfo}} | ||
| # Others | ||
| $${PWD}/SWGHelpers.h \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see below
|
@MartinDelille thanks for the PR, which has been merged into master. cc @etherealjoy as well |
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
I would like to fix #7784 by adding
client.prigeneration. This is a work in progress but I open this PR to address some problem I have with its implementation.For the Pet Store example, the resulting file should look like this:
Here are the tasks to do:
optionalProjectFileswitch to the command lineclient.priPing @ravinikam @stkrwork @fvarose