Skip to content

Hotfix/out of memory error 6394 #7625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xmeng1 wants to merge 4 commits into from
Closed

Hotfix/out of memory error 6394 #7625

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c09a9e1
limit the size of object array to 10000
xmeng1 Feb 5, 2018
47ce2ff
add warning information if the max item is too large
xmeng1 Feb 8, 2018
b41d91a
change back the import (stop auto format)
xmeng1 May 12, 2018
170e1c1
update the warning log information
xmeng1 May 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/swagger-codegen/src/main/java/io/swagger/codegen/examples/ExampleGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ private Object resolvePropertyToExample(String propertyName, String mediaType, P
if (innerType != null) {
int arrayLength = null == ((ArrayProperty) property).getMaxItems() ? 2 : ((ArrayProperty) property).getMaxItems();
if(arrayLength>10000) {
logger.warn("The max item is too large to new Object array and set it to 10000, the previous value is {}", arrayLength);
Copy link
Contributor

@dariota dariota May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning message is a bit unclear. Could you change it to something like logger.warn("The max items allowed in property {} is too large ({} items), restricting it to 10,000 items", property, arrayLength)?

arrayLength=10000;
}
Object[] objectProperties = new Object[arrayLength];
Expand Down