Skip to content

Conversation

@HugoMario
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

removed issue that trunk #9978 to be completed.
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@HugoMario HugoMario closed this Feb 11, 2020
@jdeflander
Copy link
Contributor

@HugoMario why was this closed instead of merged?

@HugoMario
Copy link
Contributor Author

HugoMario commented Feb 27, 2020

hi @jdeflander , sorry for confuse, i just made this trying to solve a sample issue on codegen with travis, but not success, original PR will be merged.

@HugoMario HugoMario deleted the elimity-com-pass-strict-null-checks branch February 27, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants