Add nullable property support from OAS 3.0 spec #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I just noticed some changes from openapi-generator. Apparently I neglected to add nullable to parameter.
I will add a similar change to parameter as well, and reference the author in the commit message. |
cognifloyd
changed the title
Contributor
|
hey @cognifloyd i already merged your PR. Can you please update this one? or give me write access to your fork and i can help you with that. |
Requires: swagger-api/swagger-codegen#8809 When I wrote this, I missed the changes on CodegenParameter and I had some unnecessary changes on CodegenModel. I realized my mistake when I went to add a similar change to openapi-generator and saw it was already there, and they knew more about what to do than I did. So, this is based in part on work by wing328 and jmini - OpenAPITools/openapi-generator#873 - OpenAPITools/openapi-generator#889 - OpenAPITools/openapi-generator#930
Contributor
Author
|
@HugoMario updated. Now Jenkins is happy. |
Contributor
|
thanks a lot @cognifloyd !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow code generators to support the nullable property in the 3.0.0, 3.0.1, and 3.0.2 specs.
This does not actually add support to any languages; it just exposes
nullableso the generators can use this standard feature.Requires: swagger-api/swagger-codegen/pull/8809 merged