Skip to content

fix: removeHiddenElems - treat <path> with opacity:0 as non-rendering node. #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: removeHiddenElems - treat <path> with opacity:0 as non-rendering node. #1948

merged 1 commit into from
Jan 29, 2024

Conversation

@johnkenny54
Copy link
Contributor

@johnkenny54 johnkenny54 commented Jan 29, 2024

removeHiddenElems was removing all <path> elements with opacity:0. If the path was referenced by a <textPath>, this caused the text to disappear.

This resolves 10 regression errors:

svgs/oxygen-icons-5.113.0/scalable/apps/digikam.svg     pass
svgs/oxygen-icons-5.113.0/scalable/apps/showfoto.svg    pass
svgs/oxygen-icons-5.113.0/scalable/apps/small/16x16/digikam.svg pass
svgs/oxygen-icons-5.113.0/scalable/apps/small/16x16/showfoto.svg        pass
svgs/oxygen-icons-5.113.0/scalable/apps/small/22x22/digikam.svg pass
svgs/oxygen-icons-5.113.0/scalable/apps/small/22x22/showfoto.svg        pass
svgs/oxygen-icons-5.113.0/scalable/apps/small/32x32/digikam.svg pass
svgs/oxygen-icons-5.113.0/scalable/apps/small/32x32/showfoto.svg        pass
svgs/oxygen-icons-5.113.0/scalable/apps/small/48x48/digikam.svg pass
svgs/oxygen-icons-5.113.0/scalable/apps/small/48x48/showfoto.svg        pass

SethFalco
SethFalco approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Happy to see tests for both, when path is referenced and not referenced too. 👍🏽

Thanks for spotting the issue and submitting a patch.

@SethFalco SethFalco merged commit f7436c7 into svg:main Jan 29, 2024
@johnkenny54 johnkenny54 deleted the removeHiddenElems branch January 30, 2024 14:58
@Latteflo Latteflo mentioned this pull request Jul 18, 2024
Open
@EmmanuelDemey EmmanuelDemey mentioned this pull request Sep 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SethFalco SethFalco SethFalco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnkenny54 @SethFalco