feat(api): idempotent default field updates; fix(docker): add ca-certificates #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ificates; docs/tests updates
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| api.update_field_default_values("proj", "field", ["val-2025-30"]) | ||
|
|
||
| # Only the incorrect one removed; nothing added | ||
| delete_calls = [call.args[0] for call in delete_mock.call_args_list] |
There was a problem hiding this comment.
call for new mock assertions
The new tests verify deletions using call.args, but call is never imported in this module. Running the test suite will raise NameError: name 'call' is not defined when the assertion executes. Import call from unittest.mock alongside MagicMock so the tests execute.
Useful? React with 👍 / 👎.
Update release date to 2025-10-08 Add version reference links Wrap long bullet to satisfy MD013 (180)
svesh
changed the title
svesh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
ca-certificateson Ubuntu 24.04, restoring TLS trust store at/etc/ssl/certs/ca-certificates.crtto fix HTTPS requests fromrequests.Changed
default values and adds only missing ones. If the current defaults already match the desired sprint, no changes are
performed.