Skip to content

chore: migrates to eslint 9 & flat config#968

Merged
sverweij merged 2 commits into
mainfrom
chore/migrate-to-eslint-9-flat-configs
Nov 24, 2024
Merged

chore: migrates to eslint 9 & flat config#968
sverweij merged 2 commits into
mainfrom
chore/migrate-to-eslint-9-flat-configs

Conversation

@sverweij
Copy link
Copy Markdown
Owner

Description

  • bumps linting setup to eslint 9
  • migrates (both) eslint configurations to 'flat config'
  • The complexity calculation changed, so I've set the max allowed complexity a little bit higher (to 10; eslint's default is 20 (!) - previously we used 6).

Our eslint-config-moving-meadow configuration is still non-flat, so @eslint/migrate-config wrapped it in a compat call, which is fine for now.

Motivation and Context

eslint 8 is EOL and won't be supported any longer. An alternative till eslint 10 is setting the ESLINT_USE_FLAT_CONFIG environment variable to false, but that still made eslint emit a warning message on each run + we had to do the work anyway, eventually.

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit b8009f0 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant