Remove %{attribute} from ko.yml errors.messages#1155
Merged
pama merged 4 commits intosvenfuchs:masterfrom Nov 23, 2025
Merged
Conversation
sunny
approved these changes
Oct 3, 2025
Contributor
sunny
left a comment
sunny
left a comment
There was a problem hiding this comment.
I don’t read Korean but technically this fixes the issue. Thank you 👍🏻
Contributor
|
An entry to the CHANGELOG would be nice 🙏🏻 |
Contributor
Author
|
@sunny Done! Who is responsible for releasing the gem? I need this change for Rails 7.2, and as far as I can tell, there's no |
Contributor
|
There’s no maintained Rails 7 branch that I know of. @pama 🙏🏻 |
Contributor
Author
|
Here is a rails-7 branch if anyone is interested. :) https://github.com/pcreux/rails-i18n/tree/rails-7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1154.
ko.ymlis the only translation file with "%{attribute}" in theerrors.messagestranslations. That raises errors since rails does not pass%{attribute}.I tasked ChatGPT/codex with fixing these translations, as I don't read Korean.
Let me know if I should update the
CHANGELOG.md.Look at #1154 for more details.