fix: align css hash in prebundling and disable hmr #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
this fixes it too but does not prevent hmr in node_modules completely |
dominikg
force-pushed
the
fix/align-css-hash
branch
from
d68b4d1 to
215d8fa
Compare
bluwy
reviewed
Jul 27, 2024
bluwy
approved these changes
Jul 27, 2024
Member
Author
|
hmr inside node_modules is blocked by 2 other problems, one being that node_modules is on vites watch ignore list by default, the other that even if you work around that watch ignore - at least with pnpm, handleHotUpdate gets called with symlink name and empty modules list so that the update is discarded by vite-plugin-svelte see vitejs/vite#8619 (comment) we can still go ahead with this PR as it is a quite minimal fix for the problem described by sveltejs/svelte#12601 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #949
this preserves hmr for dependencies that are in node_modules but excluded from optimizeDeps and also ensures that cssHash function is applied consistently so that it does not break during hydration