fix: correct first processing of boundary with pending snippet#16709
Draft
dummdidumm wants to merge 9 commits intomainfrom
Draft
fix: correct first processing of boundary with pending snippet#16709dummdidumm wants to merge 9 commits intomainfrom
dummdidumm wants to merge 9 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 03f6287 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
6 tasks
dummdidumm
commented
Sep 8, 2025
|
|
||
| if (error) { | ||
| if (error !== STALE_REACTION) { | ||
| if (error !== STALE_REACTION && !batch.branch_obsolete(effect)) { |
Member
Author
There was a problem hiding this comment.
Without this the enhanced async-block-reject-each-during-init test would fail, in other words this fixes a not-yet-reported bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16627
This adjusts the logic of the first processing of an async boundary: Previously, it would only increment/decrement the pending count of a batch on subsequent runs and otherwise deactivate the batch, but this has multiple problems:
$effects that were already picked up, because from its point of view there is no pending workAdditionally, currently after async work has finished which causes more effects (from within attachments, or top level
$effects after async work) to be created this effects are never run because they are marked as dirty, but there's no flush scheduled.The fix is
to always increment/decrement the pending countUpdate: Turns out this was on purpose, so we gotta keep not incrementing/decrementing on pending boundaries, else a state change that has causes a pending boundary to appear will be deferred which we don't want, since the async work happens "hidden" behind the pending boundary; added a test. We need to solve this differently by not collecting these effects until all async work is done$effects to the component context (todo)This also cleans up our scheduling system - everything goes through
queue_micro_tasknow, before this change batching was always in microtasks (meaning flushSync wouldn't really work correctly) and in some weird order (LIFO insteand of FIFO), andflushSyncdidn't take into account pending tasks.There's some tests failing.
One of them needs #16698 merged first, anotherone needs #16621 (that test was always failing when you tried it in the playground, weirdly the test passed up until now for some reason).The remaining need investigation.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint