fix(svelte2tsx): support for runes={false} in svelte:options #2847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <[email protected]>
🦋 Changeset detectedLatest commit: 8e59b25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
axel7083
changed the title
Signed-off-by: axel7083 <[email protected]>
Contributor
Author
Pretty weird that |
This was referenced Sep 11, 2025
dummdidumm
reviewed
Sep 12, 2025
dummdidumm
reviewed
Sep 12, 2025
Signed-off-by: axel7083 <[email protected]>
Contributor
Author
|
@dummdidumm I updated the failing test 👍 |
dummdidumm
reviewed
Sep 12, 2025
Signed-off-by: axel7083 <[email protected]>
Contributor
Author
|
@dummdidumm I added the |
Contributor
Author
|
@dummdidumm yeahh all tests are passing :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
<svelte:options runes/>were not checking for the value, so it was always true. When using<svelte:options runes={false}/>the props exported wereRecord<string, never>which is incorrect.Related issues
Fixes #2843
Testing