Skip to content

Conversation

@benmccann
Copy link
Member

@benmccann benmccann commented Sep 13, 2024

Removes a dozen dependencies

@benmccann benmccann force-pushed the chokidar-4 branch 2 times, most recently from ec8e239 to ec8721b Compare September 13, 2024 03:10
@paulmillr
Copy link

Shouldn’t second arg be default = {} instead?

@benmccann
Copy link
Member Author

Chokidar does that be internally in the watcher constructor, so it shouldn't need to be done elsewhere

@benmccann benmccann marked this pull request as draft September 13, 2024 15:04
@benmccann benmccann marked this pull request as ready for review September 23, 2024 19:27
@benmccann
Copy link
Member Author

This PR is ready for review now

@dummdidumm dummdidumm merged commit fc2144b into sveltejs:master Sep 26, 2024
3 checks passed
@benmccann benmccann deleted the chokidar-4 branch September 26, 2024 16:39
@benmccann
Copy link
Member Author

awesome. thanks for the cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants