Skip to content

Conversation

@b-fuze
Copy link
Contributor

@b-fuze b-fuze commented Jun 28, 2020

Register OnEnter rules for proper auto indenting. Fixes #236

@b-fuze
Copy link
Contributor Author

b-fuze commented Jun 28, 2020

All the lint errors seem to be related to the very long regex used in the OnEnter rules. Should I make eslint ignore those errors or attempt to fix it somehow?

@orta
Copy link
Contributor

orta commented Jun 28, 2020

hah, yeah, I'd make eslint disable the line completely

@dummdidumm
Copy link
Member

Thanks for the PR! Could you for each regex add a short comment roughly explaining what it does?

@b-fuze
Copy link
Contributor Author

b-fuze commented Jun 28, 2020

@dummdidumm I actually copied it mostly verbatim from https://github.com/microsoft/vscode/blob/master/extensions/html-language-features/client/src/htmlClient.ts#L209-L226

Should I write a short comment explaining how I understand it?

@dummdidumm
Copy link
Member

That would be great!

@b-fuze
Copy link
Contributor Author

b-fuze commented Jun 28, 2020

@dummdidumm @orta Done

@dummdidumm
Copy link
Member

👍

@dummdidumm dummdidumm merged commit f771d33 into sveltejs:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Svelte VSCode doesn't register OnEnter Rules for indentation

3 participants