-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: deploy server assets #9073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
341ad1f to
0e80480
Compare
|
Since you said this is Vite 4.1 related - is this backwards compatible? |
|
We've had a note in the past indicating that a given release only fixed a bug if you are using Vite 4.1+, which I think is a fine thing to do, but we should mention that in the changeset if that's the case. We should also make sure that this doesn't actually break anything for people still on Vite 4.0. That will probably be a manual process, because we don't currently have a good way to do that in CI. |
2a153ec to
76894d2
Compare
|
Yes, the changeset does mention Vite 4.1 I upgraded Vite to 4.1 in this PR in order to get the type for the |
closes #5240