Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Feb 11, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
magic-string ^0.27.0 -> ^0.29.0 age adoption passing confidence
undici (source) 5.18.0 -> 5.19.1 age adoption passing confidence

Release Notes

rich-harris/magic-string

v0.29.0

Compare Source

Features
  • x_google_ignoreList: initial support for ignore lists (3c711cd)

v0.28.0

Compare Source

Bug Fixes
nodejs/undici

v5.19.1

Compare Source

TBD

v5.19.0

Compare Source

What's Changed

New Contributors

Full Changelog: nodejs/undici@v5.18.0...v5.19.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@Rich-Harris
Copy link
Member

Merging this would mean duplicate copies of magic-string in people's apps, until @rollup/plugin-commonjs and @sveltejs/vite-plugin-svelte update their dependencies

@Rich-Harris
Copy link
Member

Ah wait, it's not vite-plugin-svelte that depends on [email protected], it's vite. I misread pnpm-lock.yaml. Either way, we should probably wait since 0.28 and 0.29 don't add anything we need

@renovate renovate bot changed the title chore(deps): update dependency magic-string to ^0.29.0 chore(deps): update all non-major dependencies Feb 13, 2023
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from ec82308 to 05cf91e Compare February 13, 2023 12:13
@benmccann
Copy link
Member

Ah wait, it's not vite-plugin-svelte that depends on [email protected], it's vite. I misread pnpm-lock.yaml. Either way, we should probably wait since 0.28 and 0.29 don't add anything we need

I don't think there's too much harm in bumping it. It's easier to merge this than to let the changes stack up and try to track when the appropriate time to merge this it. We don't know what version of Vite users will be using anyway

@Rich-Harris
Copy link
Member

The test failures look real. Something changed in undici

@renovate
Copy link
Contributor Author

renovate bot commented Feb 16, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this have a changeset? it probably needs a new release of adapter-netlify to happen

lgtm besides that

@Rich-Harris
Copy link
Member

it should, yeah — was just seeing if the fix was good first. adding that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants