-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
delay until ready #8739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delay until ready #8739
Conversation
|
| */ | ||
| export function forked(module, callback) { | ||
| if (process.env.SVELTEKIT_FORK) { | ||
| if (process.env.SVELTEKIT_FORK && process.send) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when would process.send be undefined? Could that happen for us (in which case this would also hang)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.send is defined if it's a child process. it's kinda redundant with the SVELTEKIT_FORK env var (though I guess someone could do SVELTEKIT_FORK vite build if they wanted to deliberately break it) but we need it or TypeScript complains
* make build phase explicit rather than using ssr as a proxy * separate build_server from build_server_nodes * extract guard plugin * simplify * simplify * remove unused code * simplify * dont quite understand this but whatever * remove unused property * simplify * simplify * reverse order * refactor * remove * skip * keep state local * use devalue for cross-process communication * DRY * separate analysis from prerendering * optimize client build * run all tests * oops * fix illegal module guard * simplify * fix prerender_map * simplify/tidy up * changeset * merge index.js and prerender.js * comment for plugin_guard * move read util to filesystem.js * remove out of date comment * tweak comment * chore: better cross-process communication (#8729) Co-authored-by: Conduitry <[email protected]> Co-authored-by: Simon Holthausen <[email protected]> * fix * see if this helps for turbo * temporarily disable turbo cache * try debug mac failure * Revert "try debug mac failure" This reverts commit 068cbe8. * delay until ready (#8739) * belts and braces Co-authored-by: Conduitry <[email protected]> Co-authored-by: Simon Holthausen <[email protected]>
another possible solution to the timeouts in #8636