Skip to content

Conversation

@Rich-Harris
Copy link
Member

another possible solution to the timeouts in #8636

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2023

⚠️ No Changeset found

Latest commit: b5faa19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

*/
export function forked(module, callback) {
if (process.env.SVELTEKIT_FORK) {
if (process.env.SVELTEKIT_FORK && process.send) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when would process.send be undefined? Could that happen for us (in which case this would also hang)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process.send is defined if it's a child process. it's kinda redundant with the SVELTEKIT_FORK env var (though I guess someone could do SVELTEKIT_FORK vite build if they wanted to deliberately break it) but we need it or TypeScript complains

@dummdidumm dummdidumm merged commit f209e73 into gh-7967-part-three Jan 26, 2023
@dummdidumm dummdidumm deleted the delay-message branch January 26, 2023 16:35
Rich-Harris added a commit that referenced this pull request Jan 26, 2023
* make build phase explicit rather than using ssr as a proxy

* separate build_server from build_server_nodes

* extract guard plugin

* simplify

* simplify

* remove unused code

* simplify

* dont quite understand this but whatever

* remove unused property

* simplify

* simplify

* reverse order

* refactor

* remove

* skip

* keep state local

* use devalue for cross-process communication

* DRY

* separate analysis from prerendering

* optimize client build

* run all tests

* oops

* fix illegal module guard

* simplify

* fix prerender_map

* simplify/tidy up

* changeset

* merge index.js and prerender.js

* comment for plugin_guard

* move read util to filesystem.js

* remove out of date comment

* tweak comment

* chore: better cross-process communication (#8729)

Co-authored-by: Conduitry <[email protected]>
Co-authored-by: Simon Holthausen <[email protected]>

* fix

* see if this helps for turbo

* temporarily disable turbo cache

* try debug mac failure

* Revert "try debug mac failure"

This reverts commit 068cbe8.

* delay until ready (#8739)

* belts and braces

Co-authored-by: Conduitry <[email protected]>
Co-authored-by: Simon Holthausen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants