Skip to content

use Vite defaults for port and strictPort #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 1 commit into from
Jul 8, 2022
Merged

use Vite defaults for port and strictPort #5392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-ducks-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

[breaking] Use Vite defaults for port and strictPort
6 changes: 0 additions & 6 deletions packages/kit/src/vite/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,6 @@ function kit() {
input: `${get_runtime_path(svelte_config.kit)}/client/start.js`
}
},
preview: {
port: config.preview?.port ?? 3000,
strictPort: config.preview?.strictPort ?? true
},
resolve: {
alias: get_aliases(svelte_config.kit)
},
Expand All @@ -177,8 +173,6 @@ function kit() {
])
]
},
port: config.server?.port ?? 3000,
strictPort: config.server?.strictPort ?? true,
watch: {
ignored: [
// Ignore all siblings of config.kit.outDir/generated
Expand Down
8 changes: 6 additions & 2 deletions packages/kit/test/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,18 @@ export const test = base.extend({
}
});

const port = 3000;

/** @type {import('@playwright/test').PlaywrightTestConfig} */
export const config = {
forbidOnly: !!process.env.CI,
// generous timeouts on CI
timeout: process.env.CI ? 45000 : 15000,
webServer: {
command: process.env.DEV ? 'npm run dev' : 'npm run build && npm run preview',
port: 3000
command: process.env.DEV
? `npm run dev -- --port ${port}`
: `npm run build && npm run preview -- --port ${port}`,
port
},
retries: process.env.CI ? 5 : 0,
projects: [
Expand Down