docs: mention nodejs_als compatibility flag#13605
docs: mention nodejs_als compatibility flag#13605elliott-with-the-longest-name-on-github merged 5 commits intosveltejs:mainfrom
nodejs_als compatibility flag#13605Conversation
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
nodejs_als compatibility flag
|
Thanks for this. Can you update the Cloudflare Workers adapter docs too? |
|
@eltigerchino I just fixed the merge conflict on this one. Do you still think we should update the Cloudflare Workers docs since the two adapters have been merged? I see there's also a Cloudflare Workers section in the Cloudflare Adapter doc. You're more familiar with Cloudflare, so I thought you might have a good suggestion of what would need to be updated |
|
Thank you!
We could because it should be the exact same as the Cloudflare docs so we can just copy and paste it.
I think we might want to suggest having the compatibility flag added in the user's Wrangler config file over using the dashboard or CLI option so that it's always set up on deployment/dev. We might also want to explain it's only needed if using |
|
opened #14189 as a possible alternative, basically forcing everyone to add this flag to avoid the warning |
|
I think we should consider merging this, at least as a stop-gap, as part of addressing #15056. Will contribute to reducing confusion/friction in the meantime. |
|
I'm going to go ahead and merge this as it's helpful in the near term. If someone wants to put the work in on the associated PR, or if there's a better fix we can arrive at, there's nothing stopping us from reverting this when the better fix is implemented. |
cf02bc9
into
sveltejs:main
* Update adapter-cloudflare documentation * docs: align with main --------- Co-authored-by: Ben McCann <[email protected]> Co-authored-by: Willow (GHOST) <[email protected]> Co-authored-by: Willow (GHOST) <[email protected]> Co-authored-by: Elliott Johnson <[email protected]>
Hello, I noticed some warning when running a cloudflare-adapter project with wrangler
npx wrangler pages dev .svelte-kit/cloudflareSeems due to the missing AsyncLocalStorage API in workers by default.
I added some instructions to the doc to enable the required compatibility flag.