Skip to content

Remove usages of waitForTimeout #2473

@benmccann

Description

@benmccann

Describe the bug

From that method's docs:

Note that page.waitForTimeout() should only be used for debugging. Tests using the timer in production are going to be flaky. Use signals such as network events, selectors becoming visible and others instead.

Reproduction

$ grep -r waitForTimeout packages/kit/test/
packages/kit/test/apps/basics/src/routes/store/_tests.js:				await page.waitForTimeout(100);
packages/kit/test/apps/basics/src/routes/routing/_tests.js:				// await page.waitForTimeout(500);
packages/kit/test/apps/basics/src/routes/no-router/_tests.js:			await page.waitForTimeout(50);
packages/kit/test/apps/basics/src/routes/no-router/_tests.js:			await page.waitForTimeout(50);
packages/kit/test/apps/basics/src/routes/accessibility/_tests.js:		await page.waitForTimeout(50);
packages/kit/test/apps/basics/src/routes/accessibility/_tests.js:		await page.waitForTimeout(50);
packages/kit/test/apps/basics/src/routes/accessibility/_tests.js:		await page.waitForTimeout(50);
packages/kit/test/apps/basics/src/routes/accessibility/_tests.js:		await page.waitForTimeout(50);
packages/kit/test/apps/basics/src/routes/session/_tests.js:			await page.waitForTimeout(10);
packages/kit/test/apps/basics/src/routes/redirect/_tests.js:			await page.waitForTimeout(100);

Logs

No response

System Info

n/a

Severity

annoyance

Additional Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions