-
Notifications
You must be signed in to change notification settings - Fork 42
fix: update performance when used with other preset #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d10011f
fix: update performance when used with other preset
mathieumure a130eb1
make it backward compatible
mathieumure c4750ec
use dediacted test for lazy load
mathieumure 5a605f0
fix
mathieumure 92951e9
add boolean option
mathieumure 8b0ec32
fix
mathieumure e876a29
revert compiler version pinning
Conduitry 97e6ae3
tidy/format; and remove cache
Conduitry 16b71e8
oops
Conduitry 23b98de
more formatting
Conduitry bd93d3b
tidy again
Conduitry d7490db
update readme
Conduitry df82f79
oh whoops, those were intentional formatting issues
Conduitry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| module.exports = { | ||
| parser: '@typescript-eslint/parser', | ||
| extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended'], | ||
| plugins: ['@typescript-eslint'], | ||
| settings: { | ||
| 'svelte3/typescript': () => require('typescript'), | ||
| }, | ||
| rules: { | ||
| indent: ['error', 'tab'], | ||
| semi: 'error', | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <script context="module"> | ||
| export const z = ''; | ||
| $: z2 = z; | ||
| </script> | ||
|
|
||
| <script lang="ts"> | ||
| export let a: any; | ||
|
|
||
| export let b: any | ||
| export let d: number; | ||
|
|
||
| const asd = d.asd(); | ||
|
|
||
| interface A {} | ||
|
|
||
| function c(x) {} | ||
| c(1); | ||
|
|
||
| $: z1 = z; | ||
| </script> | ||
|
|
||
| <o>{b}</o> | ||
| <p>{x}</p> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| [ | ||
| { | ||
| "ruleId": "module-script-reactive-declaration", | ||
| "severity": 1, | ||
| "line": 3, | ||
| "column": 2, | ||
| "endLine": 3, | ||
| "endColumn": 12 | ||
| }, | ||
| { | ||
| "ruleId": "no-undef", | ||
| "severity": 2, | ||
| "line": 3, | ||
| "column": 5, | ||
| "endLine": 3, | ||
| "endColumn": 7 | ||
| }, | ||
| { | ||
| "ruleId": "unused-export-let", | ||
| "severity": 1, | ||
| "line": 7, | ||
| "column": 13, | ||
| "endLine": 7, | ||
| "endColumn": 19 | ||
| }, | ||
| { | ||
| "ruleId": "@typescript-eslint/no-explicit-any", | ||
| "severity": 1, | ||
| "line": 7, | ||
| "column": 16, | ||
| "endLine": 7, | ||
| "endColumn": 19, | ||
| "suggestions": [ | ||
| { | ||
| "messageId": "suggestUnknown", | ||
| "fix": { | ||
| "range": [ | ||
| 58, | ||
| 61 | ||
| ], | ||
| "text": "unknown" | ||
| }, | ||
| "desc": "Use `unknown` instead, this will force you to explicitly, and safely assert the type is correct." | ||
| }, | ||
| { | ||
| "messageId": "suggestNever", | ||
| "fix": { | ||
| "range": [ | ||
| 58, | ||
| 61 | ||
| ], | ||
| "text": "never" | ||
| }, | ||
| "desc": "Use `never` instead, this is useful when instantiating generic type parameters that you don't need to know the type of." | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "ruleId": "indent", | ||
| "severity": 2, | ||
| "line": 9, | ||
| "column": 2, | ||
| "endLine": 9, | ||
| "endColumn": 3, | ||
| "fix": { | ||
| "range": [ | ||
| 112, | ||
| 113 | ||
| ], | ||
| "text": "" | ||
| } | ||
| }, | ||
| { | ||
| "ruleId": "@typescript-eslint/no-explicit-any", | ||
| "severity": 1, | ||
| "line": 9, | ||
| "column": 17, | ||
| "endLine": 9, | ||
| "endColumn": 20, | ||
| "suggestions": [ | ||
| { | ||
| "messageId": "suggestUnknown", | ||
| "fix": { | ||
| "range": [ | ||
| 79, | ||
| 82 | ||
| ], | ||
| "text": "unknown" | ||
| }, | ||
| "desc": "Use `unknown` instead, this will force you to explicitly, and safely assert the type is correct." | ||
| }, | ||
| { | ||
| "messageId": "suggestNever", | ||
| "fix": { | ||
| "range": [ | ||
| 79, | ||
| 82 | ||
| ], | ||
| "text": "never" | ||
| }, | ||
| "desc": "Use `never` instead, this is useful when instantiating generic type parameters that you don't need to know the type of." | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "ruleId": "semi", | ||
| "severity": 2, | ||
| "line": 9, | ||
| "column": 20, | ||
| "endLine": 10, | ||
| "endColumn": 2, | ||
| "fix": { | ||
| "range": [ | ||
| 130, | ||
| 130 | ||
| ], | ||
| "text": ";" | ||
| } | ||
| }, | ||
| { | ||
| "ruleId": "@typescript-eslint/no-unused-vars", | ||
| "severity": 1, | ||
| "line": 12, | ||
| "column": 8, | ||
| "endLine": 12, | ||
| "endColumn": 11 | ||
| }, | ||
| { | ||
| "ruleId": "@typescript-eslint/no-empty-interface", | ||
| "severity": 2, | ||
| "line": 14, | ||
| "column": 12, | ||
| "endLine": 14, | ||
| "endColumn": 13 | ||
| }, | ||
| { | ||
| "ruleId": "@typescript-eslint/no-unused-vars", | ||
| "severity": 1, | ||
| "line": 14, | ||
| "column": 12, | ||
| "endLine": 14, | ||
| "endColumn": 13 | ||
| }, | ||
| { | ||
| "ruleId": "@typescript-eslint/no-unused-vars", | ||
| "severity": 1, | ||
| "line": 16, | ||
| "column": 13, | ||
| "endLine": 16, | ||
| "endColumn": 14 | ||
| }, | ||
| { | ||
| "ruleId": "@typescript-eslint/no-empty-function", | ||
| "severity": 2, | ||
| "line": 16, | ||
| "column": 16, | ||
| "endLine": 16, | ||
| "endColumn": 18 | ||
| }, | ||
| { | ||
| "ruleId": "module-script-reactive-declaration", | ||
| "severity": 1, | ||
| "line": 19, | ||
| "column": 10, | ||
| "endLine": 19, | ||
| "endColumn": 11 | ||
| }, | ||
| { | ||
| "ruleId": "missing-declaration", | ||
| "severity": 1, | ||
| "line": 23, | ||
| "column": 5, | ||
| "endLine": 23, | ||
| "endColumn": 6 | ||
| }, | ||
| { | ||
| "ruleId": "no-undef", | ||
| "severity": 2, | ||
| "line": 23, | ||
| "column": 5, | ||
| "endLine": 23, | ||
| "endColumn": 6 | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| module.exports = { | ||
| parser: '@typescript-eslint/parser', | ||
| extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended'], | ||
| plugins: ['@typescript-eslint'], | ||
| settings: { | ||
| 'svelte3/typescript': true, | ||
| }, | ||
| rules: { | ||
| indent: ['error', 'tab'], | ||
| semi: 'error', | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <script context="module"> | ||
| export const z = ''; | ||
| $: z2 = z; | ||
| </script> | ||
|
|
||
| <script lang="ts"> | ||
| export let a: any; | ||
|
|
||
| export let b: any | ||
| export let d: number; | ||
|
|
||
| const asd = d.asd(); | ||
|
|
||
| interface A {} | ||
|
|
||
| function c(x) {} | ||
| c(1); | ||
|
|
||
| $: z1 = z; | ||
| </script> | ||
|
|
||
| <o>{b}</o> | ||
| <p>{x}</p> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.