Summary of tainted resources is wrong

[kyontan]

tfcmt version

v4.4.1 (latest as of 2023-06-20)

Environment

• OS: Ubuntu 22.04
• CPU Architecture: amd64

Overview

When I taint resources manually, then the plan summary is shown a bit wrongly.

# terraform taint aws_rds_cluster.postgres_temporal
Resource instance aws_rds_cluster.postgres_temporal has been marked as tainted.

reference: https://developer.hashicorp.com/terraform/cli/state/taint

The bare terraform output is:

  # aws_rds_cluster.postgres_temporal is tainted, so must be replaced
-/+ resource "aws_rds_cluster" "postgres_temporal" {
...
}

Then the tfcmt result is shown like:

- Replace
    - aws_rds_cluster.postgres_temporal is tainted, so

How to reproduce

I think this is just an omission of consideration of the case, so the tfcmt.yaml or other things are not related.

We may reproduce this by using null_resource.
(I don't have time for now, so I will append it later if needed)

Debug output

$ 

Expected behaviour

tfcmt posts the summary like:

- Replace
    - aws_rds_cluster.postgres_temporal

Actual behaviour

tfcmt posts the summary like:

- Replace
    - aws_rds_cluster.postgres_temporal is tainted, so

Important Factoids

I think fixing the regular expression is enough

• https://github.com/suzuki-shunsuke/tfcmt/blob/f9b14230fd97a428194175a0db6b307cb60d2de1/pkg/terraform/parser.go#LL70C1-L70C1

Reference

No response

[suzuki-shunsuke]

Thank you for your report!

[suzuki-shunsuke]

• fix: fix summary of tainted resources #824

[suzuki-shunsuke]

I could reproduce the issue.

$ terraform version
Terraform v1.5.0
on darwin_arm64
+ provider registry.terraform.io/hashicorp/null v3.2.1

main.tf

resource "null_resource" "foo" {}

Create a resource.

$ terraform init
$ terraform apply

Run taint.

$ terraform taint null_resource.foo
Resource instance null_resource.foo has been marked as tainted.

Run tfcmt plan.

$ tfcmt plan -- terraform plan

---

Plan Result

⚠️ Resource Deletion will happen ⚠️

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 1 to add, 0 to change, 1 to destroy.

• Replace
  • null_resource.foo is tainted, so

Change Result (Click me)

  # null_resource.foo is tainted, so must be replaced
-/+ resource "null_resource" "foo" {
      ~ id = "2678281950199183155" -> (known after apply)
    }

Plan: 1 to add, 0 to change, 1 to destroy.

[suzuki-shunsuke]

@kyontan
Would you try v4.4.2-1?
https://github.com/suzuki-shunsuke/tfcmt/releases/tag/v4.4.2-1
I think this version solves the issue.

• fix: fix summary of tainted resources #824

If there is no problem, I'll release v4.4.2.

[suzuki-shunsuke]

tfcmt v4.4.2 is out 🎉
The issue has been solved.
https://github.com/suzuki-shunsuke/tfcmt/releases/tag/v4.4.2