Update to Go 1.21#53
Merged
Merged
Conversation
konst-aa
force-pushed
the
bump-to-go121
branch
from
f40a09e to
cf138bf
Compare
The change to reverseproxy.go to make tests pass came from @marsam on GitHub.
konst-aa
force-pushed
the
bump-to-go121
branch
from
cf138bf to
8618542
Compare
suyashkumar
reviewed
Feb 4, 2024
Owner
suyashkumar
left a comment
suyashkumar
left a comment
There was a problem hiding this comment.
Thanks so much for the PR! Had a quick question/comment below.
Contributor
Author
|
@suyashkumar As you noted in your review, the tests pass on go 1.21 (tested using Act) if one removes the if statement that sets |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As go 1.19 has reached End of Life, I propose we update to go 1.21.
This PR changes the version in the
.modfile 1 line to make tests pass. The patch was done by marsam in the nixpkgs repository: NixOS/nixpkgs#282237I also successfully proxied my website, so it seems there are no breaking changes. What other testing needs to be done?