Check limit to string::replace with regular expressions #5619
+38
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuel-keller
changed the title
emmanuel-keller
changed the title
emmanuel-keller
changed the title
tobiemh
approved these changes
Mar 5, 2025
emmanuel-keller
added a commit
that referenced
this pull request
Mar 10, 2025
(cherry picked from commit 0976a94)
3 tasks
emmanuel-keller
added a commit
that referenced
this pull request
Mar 10, 2025
(cherry picked from commit 0976a94)
emmanuel-keller
added a commit
that referenced
this pull request
Mar 10, 2025
(cherry picked from commit 0976a94)
This was referenced Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request. We really appreciate you spending the time to work on SurrealDB. 🚀 🎉
What is the motivation?
When using a regular expression, the
string::replacefunction may generate excessively large strings.What does this change do?
We enforce the limit:
SURREAL_GENERATION_ALLOCATION_LIMITWhat is your testing strategy?
Github action.
A test has been added.
Is this related to any issues?
Does this change need documentation?
Have you read the Contributing Guidelines?