[BMS] StageNet with Attention#707
Merged
Merged
Conversation
Logiquo
force-pushed
the
stagenet_atten
branch
from
8895b0c to
e9b34e5
Compare
jhnwu3
requested changes
Dec 30, 2025
Collaborator
jhnwu3
left a comment
jhnwu3
left a comment
There was a problem hiding this comment.
Can we also add it to the docs/?
I think it makes sense to stack attention between each RNN pass. So it's probably good enough here. We just need to rename the StageNet layer and also check that we can pull out both the attention scores and its gradients for the attn-grad visualizations.
racoffey
pushed a commit
to jburhan/PyHealth
that referenced
this pull request
Apr 21, 2026
* Copy from stagenet * add mha to stagenet * rename * Fix test * rename class name * Add hook for attn * Add documentation * Fix docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor: Yongda Fan (yongdaf2@illinois.edu)
Contribution Type: Model
Description
Create a new model StageNet with Attention, with MHA layers inserted between SA-LSTM and SA-CNN.
Files to Review
pyhealth/models/stagenet_mha.py
tests/core/test_stagenet_mha.py