Rename Popover to ActionMenu #2914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bbab9a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Size Change: +9 B (0%) Total Size: 673 kB
ℹ️ View Unchanged
|
sirineJ
force-pushed
the
chore/DSYS-913/rename-popover
branch
from
2fd91c1 to
5f9f346
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2914 +/- ##
==========================================
- Coverage 87.98% 87.98% -0.01%
==========================================
Files 227 227
Lines 13097 13095 -2
Branches 1794 1794
==========================================
- Hits 11524 11522 -2
Misses 1519 1519
Partials 54 54
|
connor-baer
requested changes
Jan 27, 2025
.changeset/silent-moles-guess.md
Outdated
| "@sumup-oss/eslint-plugin-circuit-ui": patch | ||
| --- | ||
|
|
||
| Added a new ESLint rule to flag and replace renamed components. |
Member
There was a problem hiding this comment.
Suggested change
| Added a new ESLint rule to flag and replace renamed components. | |
| Added a new `no-renamed-components` ESLint rule to flag and replace renamed components. |
| <Props /> | ||
|
|
||
| - The reference element, which triggers ActionMenu, can be primary, secondary, tertiary buttons, an overflow icon, or components with embedded buttons such as the [ImageInput](Forms/ImageInput) component. | ||
| - Each ActionMenu action item is represented by an appropriate HTML element (e.g., a button element or an anchor element). |
Member
There was a problem hiding this comment.
Rendering the appropriate semantic element is handled internally. What's relevant to developers is that they should include href and/or onClick props.
Member
There was a problem hiding this comment.
I just realized that this is the existing documentation for the Popover component 😬
It would be wonderful if you could take the opportunity to improve it, but this isn't a blocker for the pull request.
sirineJ
force-pushed
the
chore/DSYS-913/rename-popover
branch
from
5f9f346 to
a080e81
Compare
sirineJ
force-pushed
the
chore/DSYS-913/rename-popover
branch
from
a080e81 to
bbab9a1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-913
Purpose
In order to introduce a real Popover component that can accept and display any kind of content, we need to first rename the current Popover to something that reflects its purpose. We settled on ActionMenu.
Approach and changes
Definition of done