Add jql_paged to handle large queries outside of gem#470
Open
fuzzkat wants to merge 2 commits intosumoheavy:masterfrom
Open
Add jql_paged to handle large queries outside of gem#470fuzzkat wants to merge 2 commits intosumoheavy:masterfrom
fuzzkat wants to merge 2 commits intosumoheavy:masterfrom
Conversation
5c568d5 to
7ff884e
Compare
|
I would support this change. We have tens of thousands of issues and doing a query that retrieved a large amount of them could result in consuming a lot of server memory not to much increases the order complexity of handling them. As such, we do not do any open ended .jql queries. However, if needed, we would definitely take the approach that jql_paged provides, so the system could deal with the found issues in batches. |
7ff884e to
24f9c41
Compare
24f9c41 to
095cc0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an optional addition (last two commits) to PR #468 which adds a method
Issue.jql_pagedto query by JQL but handles paging outside of the Gem.Alternatively this could replace the existing
Issue.jqlmethod.freibuis was asking for this to help handle rate limiting. I've not tested it for this purpose, but it should be possible to rescue the exception while looping by doing something like this;