Added method self.all for class Worklog#188
Open
abataloff wants to merge 2 commits intosumoheavy:masterfrom
Open
Added method self.all for class Worklog#188abataloff wants to merge 2 commits intosumoheavy:masterfrom
abataloff wants to merge 2 commits intosumoheavy:masterfrom
Conversation
Member
|
@abataloff two things on this:
|
Author
|
SimonMiaou
reviewed
Jul 21, 2017
Contributor
SimonMiaou
left a comment
There was a problem hiding this comment.
Some tests would be nice
lib/jira/resource/worklog.rb
Outdated
| response = client.get(url) | ||
| json = parse_json(response.body) | ||
| json['worklogs'].map do |worklog| | ||
| client.Worklog.build(worklog) |
Contributor
There was a problem hiding this comment.
What about using new?
json['worklogs'].map do |attrs|
self.new(client, {:attrs => attrs})
endThis would allow you to put back issue and probably make the tests green again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.