♻️(frontend) use react aria toolbar for arrow key navigation#1005
Open
♻️(frontend) use react aria toolbar for arrow key navigation#1005
Conversation
Ovgodd
force-pushed
the
refactor/reaction-toolbar-arrow-navigation
branch
from
1337d27 to
0c972f8
Compare
Ovgodd
force-pushed
the
refactor/reaction-toolbar-arrow-navigation
branch
from
0c972f8 to
926e9cc
Compare
6 tasks
Ovgodd
force-pushed
the
refactor/reaction-toolbar-arrow-navigation
branch
from
641175f to
f40ca27
Compare
| - ✨(frontend) introduce a shortcut settings tab #975 | ||
| - 🚚(frontend) rename "wellknown" directory to "well-known" #1009 | ||
| - 🌐(frontend) localize SR modifier labels #1010 | ||
| - ♻️(frontend) use react aria toolbar for arrow key navigation #1005 |
Collaborator
There was a problem hiding this comment.
something weird there.
replace focus trap with roving tabindex following WAI-ARIA toolbar pattern
allow keyboard shortcut to return focus to the emoji toolbar without closing it
Ovgodd
force-pushed
the
refactor/reaction-toolbar-arrow-navigation
branch
from
cf39a7b to
744b7c4
Compare
Ovgodd
force-pushed
the
refactor/reaction-toolbar-arrow-navigation
branch
2 times, most recently
from
db7a90d to
eee4fbc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow WAI-ARIA toolbar pattern for emoji reactions: arrow keys to navigate, Tab to dismiss.
Proposal
div[role=toolbar]+FocusScope containwith React AriaToolbar(roving tabindex)