Skip to content

Use associated types on the enum for image. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2016
Merged

Use associated types on the enum for image. #1

merged 2 commits into from
Mar 6, 2016

Conversation

@SlaunchaMan
Copy link
Contributor

@SlaunchaMan SlaunchaMan commented Jan 18, 2016

This PR removes the customImage property in favor of using the ConfettiType enum itself; the Custom case has an associated UIImage that we use.

@efremidze
Copy link

efremidze commented Jan 23, 2016

👍

@efremidze
Copy link

efremidze commented Jan 23, 2016

case Image(UIImage) might be a better name, cause custom doesn't describe the type

@sudeepag
Copy link
Owner

sudeepag commented Jan 25, 2016

Agreed, Image(UIImage) sounds like a better idea. If you go ahead and change that I can merge it right in. Thanks!

@SlaunchaMan
Copy link
Contributor Author

SlaunchaMan commented Jan 25, 2016

I like that too. Will do!

sudeepag added a commit that referenced this pull request Mar 6, 2016
@sudeepag
Merge pull request #1 from SlaunchaMan/master
abe9d68 
Use associated types on the enum for image.
@sudeepag sudeepag merged commit abe9d68 into sudeepag:master Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SlaunchaMan @efremidze @sudeepag