Add test coverage for network cache clearing on domain/path update#231
Merged
Add test coverage for network cache clearing on domain/path update#231
Conversation
Co-authored-by: JJJ <[email protected]>
Copilot
AI
changed the title
[WIP] Fix sticky cache after changing a network's domain/path
Clear network cache before domain/path update to prevent stale entries
Dec 8, 2025
Collaborator
|
@copilot Keep the tests but remove the changes to |
Co-authored-by: JJJ <[email protected]>
Contributor
Author
Copilot
AI
changed the title
Clear network cache before domain/path update to prevent stale entries
Add test coverage for network cache clearing on domain/path update
Dec 9, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds test coverage to validate that network cache is properly cleared when updating a network's domain and path through the update_network() function. This test addresses a previously reported issue where cache would remain stale after network updates, requiring manual cache flushing.
- Adds
test_update_network_clears_cache()to verify cache clearing behavior - Tests the complete update flow: create network, populate cache, update network, verify updated values
- Validates that the
clean_network_cache()call inupdate_network()works correctly
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage to validate cache behavior when updating a network's domain/path via the
update_network()function.Changes:
test_update_network_clears_cache()test case to validate that cache is properly cleared after network updateThis test ensures that the cache clearing mechanism works correctly when a network's domain and path are updated.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.