Skip to content

PHPStan Level 3#218

Merged
JJJ merged 3 commits intostuttter:masterfrom
lloc:chore/phpstan-level-3
Mar 9, 2025
Merged

PHPStan Level 3#218
JJJ merged 3 commits intostuttter:masterfrom
lloc:chore/phpstan-level-3

Conversation

@lloc
Copy link
Contributor

@lloc lloc commented Feb 28, 2025

This PR fixes 3 issues that came up with PHPStan at level 3:

  • Function get_main_site_for_network() should return int but returns false.
  • handle_row_actions should return the row actions HTML, or an empty string if the current column is not the primary column.
  • Property WPMN_Loader::$asset_version (string) does not accept default value of type int.

@lloc
Copy link
Contributor Author

lloc commented Mar 7, 2025

@JJJ @spacedmonkey Any objections? ;-)

@JJJ JJJ merged commit c367f0d into stuttter:master Mar 9, 2025
1 check passed
thefrosty added a commit to thefrosty/wp-multi-network that referenced this pull request Dec 3, 2025
* master:
  PHPStan Level 6 (stuttter#221)
  PHPStan Level 5 (stuttter#220)
  Update README.md
  PHPStan Level 4 Compliance (stuttter#219)
  PHPStan Level 3 (stuttter#218)
  PHPStan Level 2 (stuttter#217)
  PHPStan Level 1 (stuttter#215)

# Conflicts:
#	wp-multi-network/includes/classes/class-wp-ms-networks-admin.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants