Skip to content

info.plist: allow for ports-installed lpass#4

Merged
stuartcryan merged 1 commit intostuartcryan:masterfrom
jsquyres:pr/we-love-macports-too
Aug 8, 2015
Merged

info.plist: allow for ports-installed lpass#4
stuartcryan merged 1 commit intostuartcryan:masterfrom
jsquyres:pr/we-love-macports-too

Conversation

@jsquyres
Copy link
Copy Markdown

@jsquyres jsquyres commented Aug 8, 2015

In each of the scripts, check for /usr/local/bin/lpass or /opt/local/bin/lpass.

Also update your@email.com to your_email@example.com.

I'm not entirely sure which of info.plist or lastpass-cli-alfred-workflow.alfredworkflow needs to be updated, so this commit updates both.

In each of the scripts, check for /usr/local/bin/lpass or
/opt/local/bin/lpass.

Also update your@email.com to your_email@example.com.
@stuartcryan
Copy link
Copy Markdown
Owner

Howdy my good man, thank you for the input (and both need to be updated so that is awesome).

I will merge this in and release a new version on Packal and the Forums.

(and I love the branch name you used :D)

stuartcryan added a commit that referenced this pull request Aug 8, 2015
info.plist: allow for ports-installed lpass
@stuartcryan stuartcryan merged commit b7af05f into stuartcryan:master Aug 8, 2015
@stuartcryan stuartcryan added the bug label Aug 8, 2015
@stuartcryan stuartcryan added this to the Version 1.1 milestone Aug 8, 2015
@stuartcryan stuartcryan self-assigned this Aug 8, 2015
@stuartcryan
Copy link
Copy Markdown
Owner

All righty, just to update you on this, I am going to revert the change out of the master branch, however I have merged it in to devel.

I have done this after downloading and testing (granted should have done this first) as I want to change so that we store the username in the OSX Keychain so that it does not get nuked across workflow updates. This is something I have been meaning to do for some time but became apparent when I loaded up the workflow, so I figure I might as well fix this in the first update I push, rather than causing people to have to update their email addresses each time.

I will keep you posted on my progress.

Cheers,
Stuart

@jsquyres
Copy link
Copy Markdown
Author

jsquyres commented Aug 9, 2015

Sweet! Thanks for accepting the PR.

@jsquyres jsquyres deleted the pr/we-love-macports-too branch August 9, 2015 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants