Skip to content

Conversation

@nicojs
Copy link
Member

@nicojs nicojs commented Apr 24, 2020

Add a warning when options where detected that did not contribute to the option validation.

Example:

16:40:37 (23836) WARN markUnknownOptions Unknown stryker config option "concurrency".
16:40:37 (23836) WARN markUnknownOptions
   Possible causes:
   * Is it a typo on your end?
   * Did you only write this property as a comment? If so, please postfix it with "_comment".
   * You might be missing a plugin that is supposed to use it. Stryker loaded plugins from: ["@stryker-mutator/*"]
   * The plugin that is using it did not contribute explicit validation. 
   (disable "warnings.unknownOptions" to ignore this warning)`

You can still disable this by setting warnings.unknownOptions to false.

Fixes #2103

@nicojs
Copy link
Member Author

nicojs commented Apr 24, 2020

Maybe be should call the warning "unknownOptions" instead of "excessOptions". What do you think @simondel ?

@nicojs
Copy link
Member Author

nicojs commented Apr 24, 2020

I've renamed excess to unknown. In general: don't use fancy words you barely understand 😉

@nicojs nicojs changed the title feat(validation): warn about excess stryker config options feat(validation): warn about unknown stryker config options Apr 25, 2020
@nicojs nicojs merged commit 8c6fd97 into master May 13, 2020
@nicojs nicojs deleted the feat/warn-about-excess-options branch May 13, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve validation on Stryker options.

3 participants