Skip to content

Fix patch releases not automatically being used from stripe-android #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samer-stripe merged 2 commits into from
Oct 31, 2025
Merged

Fix patch releases not automatically being used from stripe-android #2191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40e8e79
Fix patch releases not automatically being used from `stripe-android`
samer-stripe Oct 30, 2025
28972b5
Update tests to not use "Pay"
samer-stripe Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ StripeSdk_compileSdkVersion=30
StripeSdk_targetSdkVersion=28
StripeSdk_minSdkVersion=21
# Keep StripeSdk_stripeVersion in sync with https://github.com/stripe/stripe-identity-react-native/blob/main/android/gradle.properties
StripeSdk_stripeVersion=21.29.0
StripeSdk_stripeVersion=21.29.+
4 changes: 2 additions & 2 deletions e2e-tests/embedded-cpm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ appId: ${APP_ID}
text: "BufoPay (test)"
- scrollUntilVisible:
element:
text: "Pay"
text: "Complete payment"
timeout: 30000
- tapOn:
text: "Pay"
text: "Complete payment"
- extendedWaitUntil:
visible: "Custom Payment Method"
timeout: 30000
Expand Down
4 changes: 2 additions & 2 deletions e2e-tests/embedded-immediate-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ appId: ${APP_ID}
optional: true

- extendedWaitUntil:
visible: "Pay"
visible: "Complete payment"
timeout: 150000
- tapOn:
text: "Pay"
text: "Complete payment"
- assertVisible:
text: "Success"
- tapOn: "OK"
2 changes: 1 addition & 1 deletion example/src/screens/EmbeddedPaymentElementConfirmScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default function EmbeddedPaymentElementConfirmScreen({

<Button
variant="primary"
title="Pay"
title="Complete payment"
onPress={handlePay}
loading={loading}
/>
Expand Down
2 changes: 1 addition & 1 deletion example/src/screens/EmbeddedPaymentElementScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ function PaymentElementView({ intentConfig, elementConfig }: any) {

<Button
variant="primary"
title="Pay"
title="Complete payment"
Copy link
Copy Markdown
Collaborator Author

@samer-stripe samer-stripe Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was noticing failures where Embedded CPM tests would fail to click "Pay". When I ran locally, I saw it would try to click any LPM that had "Pay" in it (Cash App Pay, BufoPay).

Thought maybe something unintentional changed between 21.29.0 and 21.29.2 but seems like nothing has (this after clean builds):

Before After
before after

Copy link
Copy Markdown
Collaborator Author

@samer-stripe samer-stripe Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated these tests to use Complete payment

onPress={handlePay}
loading={loading}
disabled={!paymentOption}
Expand Down