Skip to content

Fix EmbeddedPaymentElement not rendering in FlatList#2119

Closed
samer-stripe wants to merge 1 commit intomasterfrom
samer/fix-embedded-not-rendering-in-flat-list
Closed

Fix EmbeddedPaymentElement not rendering in FlatList#2119
samer-stripe wants to merge 1 commit intomasterfrom
samer/fix-embedded-not-rendering-in-flat-list

Conversation

@samer-stripe
Copy link
Copy Markdown
Collaborator

Summary

Fix EmbeddedPaymentElement not rendering in FlatList

Motivation

Ensures FlatList can be used to render EmbeddedPaymentElement in the footer.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

useState<PaymentOptionDisplayData | null>(null);
const [height, setHeight] = useState<number | undefined>();
const [height, setHeight] = useState<number | undefined>(
isAndroid ? 1 : undefined
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously not a good fix that we have to set the height to make this work. Long term its been suggested that we can get the intrinsic height to make this work.

@porter-stripe
Copy link
Copy Markdown
Collaborator

Closing in favor of #2118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants