Skip to content

Remove deprecated usage of curl_close() for PHP versions > 8.0 #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2025
Merged

Remove deprecated usage of curl_close() for PHP versions > 8.0 #1973

merged 1 commit into from
Nov 25, 2025

Conversation

@CommanderRoot
Copy link
Contributor

@CommanderRoot CommanderRoot commented Nov 25, 2025

Why?

Function curl_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in /vendor/stripe/stripe-php/lib/HttpClient/CurlClient.php on line 761

What?

Only use curl_close() on PHP versions before 8.0 when it still did something

See Also

#1972

@CommanderRoot CommanderRoot requested a review from a team as a code owner November 25, 2025 19:47
@CommanderRoot CommanderRoot requested review from jar-stripe and removed request for a team November 25, 2025 19:47
@cla-assistant
Copy link

cla-assistant bot commented Nov 25, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Nov 25, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant
Copy link

cla-assistant bot commented Nov 25, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CommanderRoot CommanderRoot mentioned this pull request Nov 25, 2025
Open
ramya-stripe
ramya-stripe approved these changes Nov 25, 2025
View reviewed changes
Copy link
Contributor

@ramya-stripe ramya-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
This will get shipped in our next release in December

@ramya-stripe ramya-stripe merged commit 4a535f3 into stripe:master Nov 25, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramya-stripe ramya-stripe ramya-stripe approved these changes

@jar-stripe jar-stripe Awaiting requested review from jar-stripe jar-stripe is a code owner automatically assigned from stripe/api-library-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CommanderRoot @ramya-stripe