Skip to content

Enable canUpdateFullPaymentMethodDetails by default for CustomerSession#10725

Merged
toluo-stripe merged 1 commit intomasterfrom
tolu/uspm/remove_feature_flag
Apr 28, 2025
Merged

Enable canUpdateFullPaymentMethodDetails by default for CustomerSession#10725
toluo-stripe merged 1 commit intomasterfrom
tolu/uspm/remove_feature_flag

Conversation

@toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Apr 24, 2025

Summary

Removes client side flag for payment method update. This means that any user who opts-into customerSessions will automatically get payment method update.

Motivation

Decision to remove client side flag

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │         uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff  
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
      dex │   4.1 MiB │   4.1 MiB │ -167 B │     9 MiB │     9 MiB │ -36 B 
     arsc │   2.5 MiB │   2.5 MiB │    0 B │   2.5 MiB │   2.5 MiB │   0 B 
 manifest │   5.4 KiB │   5.4 KiB │    0 B │  27.4 KiB │  27.4 KiB │   0 B 
      res │ 911.4 KiB │ 911.4 KiB │    0 B │   1.4 MiB │   1.4 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │   0 B 
    asset │   1.6 MiB │   1.6 MiB │    0 B │   1.6 MiB │   1.6 MiB │   0 B 
    other │ 195.4 KiB │ 195.4 KiB │   -8 B │ 369.4 KiB │ 369.4 KiB │   0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
    total │  11.8 MiB │  11.8 MiB │ -175 B │  20.9 MiB │  20.9 MiB │ -36 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 42384 │ 42382 │ -2 (+1 -3) 
   types │ 15326 │ 15326 │  0 (+0 -0) 
 classes │ 12929 │ 12929 │  0 (+0 -0) 
 methods │ 62504 │ 62504 │  0 (+1 -1) 
  fields │ 41531 │ 41532 │ +1 (+4 -3) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6302 │ 6302 │  0
APK
    compressed     │   uncompressed    │                                           
──────────┬────────┼───────────┬───────┤                                           
 size     │ diff   │ size      │ diff  │ path                                      
──────────┼────────┼───────────┼───────┼───────────────────────────────────────────
  4.1 MiB │ -167 B │     9 MiB │ -36 B │ ∆ classes.dex                             
 50.4 KiB │   -4 B │ 119.5 KiB │   0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │   -3 B │   1.2 KiB │   0 B │ ∆ META-INF/CERT.RSA                       
 53.9 KiB │   -2 B │ 119.5 KiB │   0 B │ ∆ META-INF/CERT.SF                        
    272 B │   +1 B │     120 B │   0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼────────┼───────────┼───────┼───────────────────────────────────────────
  4.2 MiB │ -175 B │   9.2 MiB │ -36 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   42384 │ 42382 │ -2 (+1 -3) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"e6aa67a","r8-mode":"full","version":"8.8.34"}
  
  - , canUpdateFullPaymentMethodDetails=false)
  - Edit Saved Card Payment Method
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"8fd3e79","r8-mode":"full","version":"8.8.34"}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   62504 │ 62504 │ 0 (+1 -1) 
  
  + s5.n <init>(boolean, boolean, boolean)
  
  - s5.n <init>(boolean, boolean)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   41531 │ 41532 │ +1 (+4 -3) 
  
  + s5.n c: boolean
  + s5.q0 g: boolean
  + s5.q0 h: c
  + s5.q0 j: boolean
  
  - r5.g f: f
  - s5.q0 g: c
  - s5.q0 h: boolean

@toluo-stripe toluo-stripe force-pushed the tolu/uspm/remove_feature_flag branch 2 times, most recently from ac88710 to a9a924d Compare April 28, 2025 06:23
@toluo-stripe toluo-stripe force-pushed the tolu/uspm/remove_feature_flag branch from a9a924d to 4db582b Compare April 28, 2025 14:24
@toluo-stripe toluo-stripe marked this pull request as ready for review April 28, 2025 14:30
@toluo-stripe toluo-stripe requested review from a team as code owners April 28, 2025 14:30
@toluo-stripe toluo-stripe enabled auto-merge (squash) April 28, 2025 14:41
@toluo-stripe toluo-stripe merged commit 220c239 into master Apr 28, 2025
16 checks passed
@toluo-stripe toluo-stripe deleted the tolu/uspm/remove_feature_flag branch April 28, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants