Skip to content

Change VerticalModeFormHeaderUI text color to onSurface#10492

Merged
tjclawson-stripe merged 5 commits intomasterfrom
tyler/mobilesdk-3340
Mar 25, 2025
Merged

Change VerticalModeFormHeaderUI text color to onSurface#10492
tjclawson-stripe merged 5 commits intomasterfrom
tyler/mobilesdk-3340

Conversation

@tjclawson-stripe
Copy link
Collaborator

@tjclawson-stripe tjclawson-stripe commented Mar 25, 2025

Summary

Change VerticalModeFormHeaderUI text color from onComponent to onSurface

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-3340

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

onComponent: Green
onSurface: Red

Before After
header_text_color_before header_text_color_after

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │  0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.4 KiB │   7.4 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │  95.2 KiB │  95.1 KiB │ -6 B │ 182.4 KiB │ 182.4 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -6 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20144 │ 20144 │ 0 (+0 -0) 
   types │  6235 │  6235 │ 0 (+0 -0) 
 classes │  5026 │  5026 │ 0 (+0 -0) 
 methods │ 30045 │ 30045 │ 0 (+0 -0) 
  fields │ 17388 │ 17388 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3644 │ 3644 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 25.7 KiB │ -3 B │    64 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    270 B │ -2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
   29 KiB │ -2 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 56.1 KiB │ -6 B │ 129.4 KiB │  0 B │ (total)

@tjclawson-stripe tjclawson-stripe marked this pull request as ready for review March 25, 2025 19:56
@tjclawson-stripe tjclawson-stripe requested review from a team as code owners March 25, 2025 19:56
@tjclawson-stripe tjclawson-stripe merged commit dadcae1 into master Mar 25, 2025
13 checks passed
@tjclawson-stripe tjclawson-stripe deleted the tyler/mobilesdk-3340 branch March 25, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants