#2779 CrdGenerator validate @JsonPropertyOrder
#9831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffen-karlsson
force-pushed
the
2779-validating-crdgenerator
branch
2 times, most recently
from
ae8b9df to
34024bf
Compare
steffen-karlsson
force-pushed
the
2779-validating-crdgenerator
branch
2 times, most recently
from
069620b to
9cbc7e1
Compare
added 11 commits
March 14, 2024 10:03
Signed-off-by: Steffen Karlsson <[email protected]>
…m happening while compiling Signed-off-by: Steffen Karlsson <[email protected]>
Signed-off-by: Steffen Karlsson <[email protected]>
Signed-off-by: Steffen Karlsson <[email protected]>
Signed-off-by: Steffen Karlsson <[email protected]>
Signed-off-by: Steffen Karlsson <[email protected]>
Signed-off-by: Steffen Karlsson <[email protected]>
Signed-off-by: Steffen Karlsson <[email protected]>
Signed-off-by: Steffen Karlsson <[email protected]>
Signed-off-by: Steffen Karlsson <[email protected]>
Signed-off-by: Steffen Karlsson <[email protected]>
steffen-karlsson
force-pushed
the
2779-validating-crdgenerator
branch
from
0502e5c to
e3f98ee
Compare
scholzj
reviewed
Mar 14, 2024
Member
scholzj
left a comment
scholzj
left a comment
There was a problem hiding this comment.
Thanks for the PR. I think this looks good - I didn't realized we were missing it on so many classes. I will run the regression tests on this as well.
Author
Was also surprised when I started adjusting the classes :D |
Member
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Validating existence of
@JsonPropertyOrderand that all relevant fields in class are present in the@JsonPropertyOrderChecklist